Lots of grammar/spelling issues & rewrote some docs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deccer
requested changes
May 5, 2022
| about odd fractionals to manually scale the windowsize for any arbitrary scaling on your OS. | ||
| This will tell `GLFW` to not scale the window in any way, should you have set up a specific scaling | ||
| other than 100% on your desktop. That will keep the window size at what we set it, without thinking | ||
| about odd fractional to manually scale the window size for any arbitrary scaling on your OS. |
There was a problem hiding this comment.
hmm, isn't the right word fractions?
There was a problem hiding this comment.
I've changed it to , and lets us forget about fractional window and pixel scaling.. I think that's more understandable than what we currently have.
docs/1-introduction/1-1-getting-started/1-1-3-hello-triangle.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a lot of grammar and spelling issues throughout the first chapter (1-1-getting-started). Some changes are just sentences I reworded because they didn't sound good at all. I also rewrote
index.mdand1-1-0-overview.mdwith better language and more content, hopefully appealing more to new readers and beginners. I also tried to enforce a 100 line column limit in some files so that the markdown text is easier to read and write, as there are a few occurrences of 300 to 500 long lines and it is nearly impossible to read them on GitHub or an editor that doesn't have line break enabled by default.Partial fix to #42.