Edge to edge 3 #538
Open
Edge to edge 3 #538
+137
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octocorvus
force-pushed
the
edge-to-edge-3
branch
2 times, most recently
from
7cd0755 to
0c4cb49
Compare
The page element is a container for the canvas and text layer and helps to keep the layers aligned. The following changes were also needed: - Only center PDF pages horizontally. Vertical centering was often the cause of text layer misalignment and additional code was often needed to fix the alignment. Moreover, vertical centering doesn't make sense when there are multiple PDF pages within the same DOM. So, drop it completely. - Drop old text layer alignment method.
We add padding to account for system insets and app toolbar size.
Prevents jank which happens due to --scale-factor not being set to correct value before canvas is displayed.
Allows gradle to determine whether running a task is necessary or not.
octocorvus
force-pushed
the
edge-to-edge-3
branch
from
0c4cb49 to
4eec34d
Compare
octocorvus
force-pushed
the
edge-to-edge-3
branch
from
24338c1 to
6789285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.