Skip to content

Data Binding Fixes #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Data Binding Fixes #6565

wants to merge 22 commits into from

Conversation

mohamedsalem401
Copy link
Member

@mohamedsalem401 mohamedsalem401 commented Jul 14, 2025 •
edited
Loading

  • Add unit tests for UndoManager

Bug fixes related to the unit tests

  • Fix issue updating UI after binding to a data variable with undefined as value
  • Allow CssRules to have values from collection variables
  • Fix saving CssRules with dynamic values
  • Fix UndoManager issue with data variablesA
  • Add UndoManager to Datasources module
  • Refactor DataResolver watchers

@mohamedsalem401
Fix saving dynamic values for cssRules
576a9e7
@mohamedsalem401
Allow using collectionStateMap for styleable models
2005bf3
@mohamedsalem401
Fix bug with undo manager
9c3197c
@mohamedsalem401
refactor resolverWatcher
9b9a4a7
@mohamedsalem401
Allow CssRules to use collection variable
9dc64b5
@mohamedsalem401
Fix undoManager issue for binding data to a component
b5cb2e3
@mohamedsalem401
update returned value for adding props
8c3e2d2
@mohamedsalem401
Revert a change to fix tests
f761af0
@mohamedsalem401
Merge branch 'dev' of https://github.com/GrapesJS/grapesjs into data-…
827c64d 
…binding-fixes
@mohamedsalem401
move test files
48de55f
@mohamedsalem401
Add tests for undomanager with datasources
2cf7473
@mohamedsalem401
update clone and toJSON for cssRule
c2c43b8
@mohamedsalem401
Refactor Model data resolver
8d3a3ab
@mohamedsalem401
update test setup function
ff45669
@mohamedsalem401
Refactor datasources logic to styleable model
cdc1471
@mohamedsalem401
Add clone and update toJSON in styleableModel
29c6eeb
@mohamedsalem401
Refactor CssRule to use styleableModel methods
d74bbb3
@mohamedsalem401
Add undomanager to datasources
5b56952
@mohamedsalem401
refactor component class to use styleableModel methods
6ecd00a
@mohamedsalem401
update unit tests for undo manager
4d76388
@mohamedsalem401
Refactor data resolver watcher
49459a3
@mohamedsalem401
Fix undoManager in test enviroment
b2b9786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mohamedsalem401