fix: add file-type and size validation to avatar upload with toast notifications - #955
Open
waterWang wants to merge 1 commit into
Open
fix: add file-type and size validation to avatar upload with toast notifications#955waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…tifications Replace native alert() calls with toast.error() for avatar upload validation errors, reject SVG uploads (XSS security risk), and add WebP support. Add focused tests for rejected file types, oversized files, and valid uploads. Closes Grainlify#509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace native
alert()calls withtoast.error()for avatar upload validation errors, reject SVG uploads (XSS security risk), and add WebP support for the accepted file types.Changes
ProfileTab.tsx
<script>). Allowed types: PNG, JPG, GIF, WebPtoast.error()instead ofalert()so errors are consistent with the app's existing notification system<input accept="...">to match validated typesProfileTab.test.tsx
Closes #509