fix: surface useLandingStats error and loading state in WhyChooseUs section (Closes #878) - #954
Open
waterWang wants to merge 1 commit into
Open
Conversation
…ection (Closes Grainlify#878) The WhyChooseUs component only destructured `display` from `useLandingStats()`, silently ignoring `isLoading` and `error`. Changes: - Destructure isLoading and error alongside display - Show animate-pulse skeleton placeholders while stats load - Show error fallback with alert role when stats fail to load - Add test cases for loading, error, and success states Fixes Grainlify#878
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
WhyChooseUssection only destructureddisplayfromuseLandingStats(), silently ignoring theisLoadinganderrorstates. When the API was loading or failed, users saw em-dashes (—) with no visual feedback.Changes
WhyChooseUsnow destructuresisLoadinganderroralongsidedisplayanimate-pulseskeleton placeholders for the Active Users and Projects Funded stats while the API request is in flightrole="alert"when stats fail to load, with a user-friendly messageScreenshots
Closes #878