fix: mount LeaderboardStyles keyframes on LeaderboardPage (Closes #708) - #949
Open
waterWang wants to merge 1 commit into
Open
fix: mount LeaderboardStyles keyframes on LeaderboardPage (Closes #708)#949waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…inlify#708) LeaderboardStyles.tsx defines @Keyframes for podium/hero animations (glow-pulse, float, twinkle-slow, etc.) but the component was never imported or rendered anywhere, so all animation classes were silently no-ops. - Import and render <LeaderboardStyles /> in LeaderboardPage.tsx (following the same pattern as BlogPage + BlogStyles) - Add regression tests verifying the <style> tag containing @Keyframes glow-pulse is rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LeaderboardStyles.tsx defines @Keyframes for podium/hero animations (glow-pulse, float, twinkle-slow, etc.) but the component was never imported or rendered anywhere, so all animation classes were silently no-ops.
Changes
<LeaderboardStyles />in LeaderboardPage.tsx, following the same pattern as BlogPage + BlogStyles<style>tag containing@keyframes glow-pulse,@keyframes float, and@keyframes twinkle-slowis renderedVerification
✓ src/features/leaderboard/components/LeaderboardStyles.test.tsx (3 tests)Closes #708