Repository navigation
fix(ci): install the Playwright browsers the pinned version expects - #1326
Merged
Merged
Conversation
…pects bunx run from the repo root found no local playwright binary, because the isolated linker installs it only under packages/deep-heating, so it fetched the latest playwright from npm and downloaded that version's browsers instead.
Playwright test results
Details
Skipped testspop-out.spec.ts › Popping Out › user can pop out and cancel to return to normal schedule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pull request that runs the build job has failed its E2E tests since early October, because Playwright could not find its Chromium headless shell.
The install step ran
bunx playwrightfrom the repo root. Bun's isolated linker puts theplaywrightbinary only underpackages/deep-heating, sobunxfound nothing locally and fetched the latest Playwright from npm (1.64.1). That version downloaded its own browser build, while the tests run the pinned 1.57.0 and look for an older one.Both install steps now run from
packages/deep-heating, so they use the pinned Playwright and download the browsers it expects.