Skip to content

Correct the Kdoc for relocate #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Mar 25, 2025

Follow up #1368.

@Goooler Goooler enabled auto-merge (squash) March 25, 2025 09:20
@Goooler Goooler changed the title Correct the Kdoc for relocate Correct the Kdoc for relocate Mar 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the Kdoc for the relocate methods in the ShadowJar class to include resources in addition to classes. The changes are straightforward and improve the accuracy of the documentation.

Merge Readiness

The changes are straightforward and improve the accuracy of the documentation. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the low impact and the positive nature of the change, this pull request is ready to be merged.

@Goooler Goooler merged commit 4fbaea4 into main Mar 25, 2025
7 checks passed
@Goooler Goooler deleted the g/20250325/correct-relocate-comments branch March 25, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant