-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(deps): update apache/beam_python3.10_sdk docker tag to v2.69.0 #13647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update apache/beam_python3.10_sdk docker tag to v2.69.0 #13647
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Apache Beam Python 3.10 SDK Docker image version across multiple Dockerfiles within the repository. The change from version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the apache/beam_python3.10_sdk Docker image tag to v2.69.0 across several Dockerfiles. However, this introduces a version mismatch with the apache-beam library version specified in the corresponding requirements.txt files for each example. For Apache Beam to function correctly, the SDK version from the base image and the library version used in the pipeline code must match. I've left comments on each Dockerfile to highlight the specific requirements.txt file that needs to be updated. Please update the apache-beam dependency in all relevant requirements.txt files to 2.69.0 to resolve these potential runtime issues.
| # use the image as SDK container image. | ||
| # The Beam version should match the version specified in requirements.txt | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Beam SDK version in the Docker FROM instruction (2.69.0) does not match the apache_beam version in dataflow/gemma-flex-template/requirements.txt (2.66.0). As noted in the comment on line 32, these versions should match to avoid runtime issues. Please update the apache_beam version in requirements.txt to 2.69.0.
|
|
||
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| # Check this matches the apache-beam version in the requirements.txt | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Beam SDK version (2.69.0) does not match the apache-beam version in dataflow/gpu-examples/tensorflow-landsat-prime/requirements.txt (2.58.1). As the comment on line 37 suggests, these versions should match. Please update the apache-beam version in requirements.txt to 2.69.0 to ensure compatibility.
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| # Check this matches the apache-beam version in the requirements.txt | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| # Check this matches the apache-beam version in the requirements.txt | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Set the entrypoint to Apache Beam SDK worker launcher. | ||
| # Check this matches the apache-beam version in the requirements.txt | ||
| COPY --from=apache/beam_python3.10_sdk:2.62.0 /opt/apache/beam /opt/apache/beam | ||
| COPY --from=apache/beam_python3.10_sdk:2.69.0 /opt/apache/beam /opt/apache/beam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains the following updates:
2.62.0->2.69.02.62.0->2.69.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.