Skip to content

feat(parametermanager): Added samples for handling CMEK in Parameter for Global and Regional #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suvidha-malaviya
Copy link

Description

Added samples for Global and Regional Parameter Manager API with CMEK key

  • create_param_with_kms_key
  • update_param_kms_key
  • remove_param_kms_key
  • create_regional_param_with_kms_key
  • update_regional_param_kms_key
  • remove_regional_param_kms_key

Added test cases for both global and regional parameter.
Note: The KMS service needs to be enabled in the testing project to pass the integration tests.

Checklist

  • I have followed guidelines from the CONTRIBUTING.MD
  • Appropriate changes to README are included in PR
  • Test passed: ../testing/vendor/bin/phpunit test/ -v
  • Lint passed: php-cs-fixer fix . --config .php-cs-fixer.dist.php
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 2, 2025
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! LGTM

@suvidha-malaviya suvidha-malaviya marked this pull request as ready for review May 2, 2025 05:46
@suvidha-malaviya suvidha-malaviya requested review from a team as code owners May 2, 2025 05:46
Copy link

snippet-bot bot commented May 2, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants