feat(parametermanager): Added global and regional samples for parameter manager #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
|
Here is the summary of changes. You are about to add 30 region tags.
This comment is generated by snippet-bot.
|
|
Raised a duplicate of this PR #2079 because Vatsal's CLA has expired, which is blocking the merge. Once the new PR is merged, will close the original one. |
bshaffer
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
this is really well done! I was able to run the tests locally and they all passed.
I made some minor suggestions for how to construct the JSON payload - it's more idiomatic to call json_encode on a PHP array than hardcode a string. But this is minor, so, approved!
| $parent = $client->parameterName($projectId, 'global', $parameterId); | ||
|
|
||
| // Build payload. | ||
| $payload = sprintf('{"username": "test-user", "password": "__REF__(//secretmanager.googleapis.com/%s)"}', $secretId); |
There was a problem hiding this comment.
This would be better off using json_encode:
Suggested change
| $payload = sprintf('{"username": "test-user", "password": "__REF__(//secretmanager.googleapis.com/%s)"}', $secretId); | |
| $payload = json_encode([ | |
| 'username' => 'test-user', | |
| 'password' => sprintf('__REF__(//secretmanager.googleapis.com/%s)', $secretId) | |
| ]); |
| $parent = $client->parameterName($projectId, $locationId, $parameterId); | ||
|
|
||
| // Build payload. | ||
| $payload = sprintf('{"username": "test-user", "password": "__REF__(//secretmanager.googleapis.com/%s)"}', $secretId); |
There was a problem hiding this comment.
Same with this one - might be better to use json_encode
| printf('Created parameter %s with format %s' . PHP_EOL, $newParameter->getName(), ParameterFormat::name($newParameter->getFormat())); | ||
|
|
||
| // Create a new ParameterVersionPayload object and set the json data. | ||
| $payload = '{"username": "test-user", "host": "localhost"}'; |
There was a problem hiding this comment.
Suggested change
| $payload = '{"username": "test-user", "host": "localhost"}'; | |
| $payload = json_encode(['username' => 'test-user', 'host' => 'localhost']); |
| printf('Created regional parameter %s with format %s' . PHP_EOL, $newParameter->getName(), ParameterFormat::name($newParameter->getFormat())); | ||
|
|
||
| // Create a new ParameterVersionPayload object and set the json data. | ||
| $payload = '{"username": "test-user", "host": "localhost"}'; |
5 tasks
|
Closing as duplicate of #2079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created samples for Global and Regional Parameter Manager API
Samples (Global, Regional)
quickstart
parameter-structured-data
parameter-unstructured-data
add-parameter-version (structured, unstructured)
create-parameter-secret-reference
list-all-parameters
view-parameter-details
delete-parameter
list-all-parameters-versions
view-parameter-version-details
render-secret-parameter-version
disable-parameters-version
enable-disabled-parameters-version
delete-parameter-version
Checklist
../testing/vendor/bin/phpunit test/ -vphp-cs-fixer fix . --config .php-cs-fixer.dist.php