Memorystore Valkey Multi vpc support

[NA2047]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

google_memorystore_instance_desired_user_created_connections

redis: added `psc_attachment_details` field to `google_memorystore` resource, to enable use of the fine-grained resource `google_memorystore_instance_desired_user_created_connections

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1562 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 8 files changed, 1558 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 211 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_memorystore_instance_desired_user_created_connections (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_memorystore_instance_desired_user_created_connections" "primary" {
  desired_instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
  effective_instance_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
  name   = # value needed
  region = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

• google_memorystore_instance_desired_user_created_connections

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• memorystore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccMemorystoreInstance_updateInstanceEndpoints

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_updateInstanceEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test