Confidential compute for workbench instances

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: added `confidential_instance_config` field to `google_workbench_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+))
google-beta provider: Diff ( 4 files changed, 116 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workbench_instance (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workbench_instance" "primary" {
  gce_setup {
    confidential_instance_config {
      confidential_instance_type  = # value needed
      enable_confidential_compute = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+))
google-beta provider: Diff ( 4 files changed, 116 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_workbench_instance (48 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_workbench_instance" "primary" {
  gce_setup {
    confidential_instance_config {
      confidential_instance_type  = # value needed
      enable_confidential_compute = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 118 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 118 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 22
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 4 files changed, 194 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 125 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+))
google-beta provider: Diff ( 4 files changed, 194 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 41 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 125 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• workbench

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test