Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage_project_management_hub resource. #12689

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kautikdk
Copy link
Member

@kautikdk kautikdk commented Jan 6, 2025

This PR adds support for GCS Management Hub on Project level.

Related Issue(Doesn't fix): hashicorp/terraform-provider-google#20763

`google_storage_project_management_hub`

@github-actions github-actions bot requested a review from trodge January 6, 2025 06:49
Copy link

github-actions bot commented Jan 6, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@kautikdk kautikdk marked this pull request as draft January 6, 2025 06:50
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 273 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storage
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageProjectManagementHub_update
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 273 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storage
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccStorageProjectManagementHub_update
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1100 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 273 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 116
Passed tests: 106
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageProjectManagementHub_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageProjectManagementHub_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1212 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1212 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 273 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 116
Passed tests: 106
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageProjectManagementHub_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageProjectManagementHub_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants