Add Gemini Code Assist for Google Cloud resources #12181

JumiDeluxe · 2024-10-29T13:53:23Z

Add new resources for Gemini Code Assist

Release Note Template for Downstream PRs (will be copied)

`google_gemini_code_repository_index`

`google_gemini_repository_group`

github-actions · 2024-10-29T13:54:05Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-10-29T14:04:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_geminifor_google_cloud_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_geminifor_google_cloud_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_repository_group" "primary" {
  labels = # value needed
}

frsv · 2024-10-29T14:18:50Z

mmv1/products/cloudaicompanion/product.yaml

+# limitations under the License.
+
+---
+name: GeminiforGoogleCloud


Looking at other examples, this should be just "Gemini"

It's also worth sharing that with this being a new service you'll want include it in the list of teamcity services which is mentioned in the failing teamcity diff check: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/11576174691/job/32224494242?pr=12181

You'll also need to include cloudaicompanion.googleapis.com as part of the services that our CI has which is done here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/infra/terraform/main.tf

An example of a service being added can be found here. This will need to be done in a separate PR

Simplified to Gemini.
I've included the cloudaicompanion.googleapis.com service in the #12186 PR.
Teamcity services also added for GA and beta.

frsv · 2024-10-29T14:19:05Z

mmv1/templates/terraform/examples/geminifor_google_cloud_code_repository_index_basic.tf.tmpl

@@ -0,0 +1,4 @@
+resource "google_geminifor_google_cloud_code_repository_index" "example_cri" {


This looks awkward. If my understanding is correct, the prefix is taken from product.yaml name field. After you update the name, I expect the resource to be "google_gemini_code_repository_index"

Name simplification shortened resources names to google_gemini_repository_group and google_gemini_code_repository_index. Updating the issue description

modular-magician · 2024-10-29T14:47:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_geminifor_google_cloud_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_geminifor_google_cloud_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_repository_group" "primary" {
  labels = # value needed
}

modular-magician · 2024-10-29T15:16:24Z

Tests analytics

Total tests: 4222
Passed tests: 3796
Skipped tests: 421
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceConfidentialInstanceConfigMain

TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

TestAccContainerCluster_resourceManagerTags

TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample

TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-10-29T15:34:52Z

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_resourceManagerTags [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-29T16:00:01Z

Tests analytics

Total tests: 4222
Passed tests: 3797
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceConfidentialInstanceConfigMain

TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample

TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-10-29T16:17:15Z

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…y timeouts

modular-magician · 2024-10-29T19:47:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

modular-magician · 2024-10-29T19:48:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

modular-magician · 2024-10-29T19:52:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

modular-magician · 2024-10-29T20:00:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

modular-magician · 2024-10-29T20:27:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 20 files changed, 2177 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 18 files changed, 2167 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

BBBmau · 2024-10-29T20:39:31Z

mmv1/third_party/terraform/.teamcity/components/inputs/services_ga.kt

@@ -141,6 +141,11 @@ var ServicesListGa = mapOf(
        "displayName" to "Certificatemanager",
        "path" to "./google/services/certificatemanager"
    ),
+    "gemini" to mapOf(


the service name should be cloudaicompanion and not gemini since the service is cloudaicompanion.

I've reverted the teamcity service name change commit.
Hm, the teamcity-services-diff-check is also looking for the gemini service. Should we add a duplicate entry pointing at the cloudaicompanion path? I wonder how it is determined, since it wants the service to be mapped under both names.

modular-magician · 2024-10-29T20:55:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 20 files changed, 2177 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 18 files changed, 2167 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

modular-magician · 2024-10-29T21:01:04Z

Tests analytics

Total tests: 4226
Passed tests: 3804
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-10-29T21:01:44Z

Tests analytics

Total tests: 4226
Passed tests: 3804
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-10-29T21:03:21Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-29T21:04:09Z

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-13T14:18:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 558 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 3572 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-13T15:31:10Z

Tests analytics

Total tests: 4297
Passed tests: 3881
Skipped tests: 410
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroup_update

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

TestAccContainerCluster_withFleetConfig

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-11-13T15:46:04Z

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-13T17:08:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 558 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 3573 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-13T18:22:28Z

Tests analytics

Total tests: 4297
Passed tests: 3881
Skipped tests: 410
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroup_update

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

TestAccContainerCluster_withFleetConfig

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-11-13T18:37:43Z

🟢 Tests passed during RECORDING mode:
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-13T21:36:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 558 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 3574 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-13T22:51:35Z

Tests analytics

Total tests: 4297
Passed tests: 3882
Skipped tests: 410
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroup_update

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

modular-magician · 2024-11-13T22:57:15Z

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-13T23:26:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 558 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 3574 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-14T00:39:08Z

Tests analytics

Total tests: 4297
Passed tests: 3883
Skipped tests: 410
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccGeminiCodeRepositoryIndex_update
TestAccGeminiRepositoryGroup_update

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

TestAccGeminiRepositoryGroupIamBindingGenerated

TestAccGeminiRepositoryGroupIamMemberGenerated

TestAccGeminiRepositoryGroupIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2024-11-14T00:44:11Z

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…custom update and create, add labels, move templates to gemini

mmv1/products/cloudaicompanion/CodeRepositoryIndex.yaml

mmv1/templates/terraform/custom_create/repository_group.go.tmpl

mmv1/third_party/terraform/services/gemini/iam_gemini_repository_group_test.go.tmpl

mmv1/third_party/terraform/services/gemini/resource_gemini_code_repository_index_test.go.tmpl

mmv1/templates/terraform/custom_create/repository_group.go.tmpl

modular-magician · 2024-11-15T16:55:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 548 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 23 files changed, 3076 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 594 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_repository_group_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_gemini_repository_group_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

modular-magician · 2024-11-15T18:08:42Z

Tests analytics

Total tests: 4298
Passed tests: 3881
Skipped tests: 410
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample

TestAccBackupDRBackupVault_fullUpdate

TestAccGeminiCodeRepositoryIndex_update

TestAccGeminiRepositoryGroupIamBinding

TestAccGeminiRepositoryGroupIamMember

TestAccGeminiRepositoryGroupIamPolicy

TestAccGeminiRepositoryGroup_update

Get to know how VCR tests work

modular-magician · 2024-11-15T18:17:41Z

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccGeminiRepositoryGroupIamBinding [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMember [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicy [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

JumiDeluxe · 2024-12-03T16:21:25Z

This PR was split into two separate PRs, #12338 and #12424, both merged.
Closing this PR.

github-actions bot requested a review from BBBmau October 29, 2024 13:54

frsv reviewed Oct 29, 2024

View reviewed changes

Add Gemini for Google Cloud provider

67544d1

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 7210cb2 to 67544d1 Compare October 29, 2024 14:36

JumiDeluxe mentioned this pull request Oct 29, 2024

add new cloudaicompanion service into .ci/infra/terraform/main.tf #12186

Merged

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 077fcf4 to 23487f1 Compare October 29, 2024 19:37

Simplify service name to Gemini, add Acc tests and .teamcity, modif…

9376ec2

…y timeouts

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 23487f1 to 9376ec2 Compare October 29, 2024 19:41

BBBmau reviewed Oct 29, 2024

View reviewed changes

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 10c3aa0 to 9b6320e Compare October 29, 2024 20:43

github-actions bot requested a review from BBBmau October 29, 2024 20:44

This was referenced Oct 29, 2024

add new cloudaicompanion service into .ci/infra/terraform/main.tf hashicorp/terraform-provider-google#20092

Merged

add new cloudaicompanion service into .ci/infra/terraform/main.tf hashicorp/terraform-provider-google-beta#8553

Merged

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 23f2256 to c5b0adb Compare November 13, 2024 16:57

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from c5b0adb to 8dc3c36 Compare November 13, 2024 21:25

Add PreApply to RepositoryGroup and CodeRepositoryIndex update tests

f51b6a3

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 8dc3c36 to f51b6a3 Compare November 13, 2024 23:16

melinath mentioned this pull request Nov 14, 2024

Update generated IAM acceptance tests to include conditions, or omit IAM conditions from missing test detector hashicorp/terraform-provider-google#18215

Open

Remove autogenerated RepositoryGroup, CodeRepositoryIndex tests, add …

6e98540

…custom update and create, add labels, move templates to gemini

frsv reviewed Nov 15, 2024

View reviewed changes

mmv1/products/cloudaicompanion/CodeRepositoryIndex.yaml Outdated Show resolved Hide resolved

mmv1/templates/terraform/custom_create/repository_group.go.tmpl Show resolved Hide resolved

frsv reviewed Nov 15, 2024

View reviewed changes

mmv1/third_party/terraform/services/gemini/iam_gemini_repository_group_test.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/gemini/resource_gemini_code_repository_index_test.go.tmpl Outdated Show resolved Hide resolved

Change CodyRepositoryIndex control labels

be8cc8c

frsv reviewed Nov 15, 2024

View reviewed changes

mmv1/templates/terraform/custom_create/repository_group.go.tmpl Outdated Show resolved Hide resolved

Update CodeRepositoryIndex and RepositoryGroup 409 error handling

2eec99a

JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 6fbcd65 to 2eec99a Compare November 15, 2024 16:13

JumiDeluxe marked this pull request as draft November 15, 2024 17:21

JumiDeluxe closed this Dec 3, 2024

		@@ -0,0 +1,4 @@
		resource "google_geminifor_google_cloud_code_repository_index" "example_cri" {

Add Gemini Code Assist for Google Cloud resources #12181

Add Gemini Code Assist for Google Cloud resources #12181

Conversation

JumiDeluxe commented Oct 29, 2024 • edited Loading

github-actions bot commented Oct 29, 2024

modular-magician commented Oct 29, 2024

Diff report

Missing test report

frsv Oct 29, 2024

Choose a reason for hiding this comment

BBBmau Oct 29, 2024

Choose a reason for hiding this comment

JumiDeluxe Oct 29, 2024

Choose a reason for hiding this comment

frsv Oct 29, 2024

Choose a reason for hiding this comment

JumiDeluxe Oct 29, 2024

Choose a reason for hiding this comment

modular-magician commented Oct 29, 2024

Diff report

Missing test report

modular-magician commented Oct 29, 2024

Tests analytics

Action taken

modular-magician commented Oct 29, 2024

modular-magician commented Oct 29, 2024

Tests analytics

Action taken

modular-magician commented Oct 29, 2024

modular-magician commented Oct 29, 2024

Diff report

Missing test report

modular-magician commented Oct 29, 2024

Diff report

Missing test report

modular-magician commented Oct 29, 2024

Diff report

Missing test report

modular-magician commented Oct 29, 2024

Diff report

Missing test report

modular-magician commented Oct 29, 2024

Diff report

BBBmau Oct 29, 2024

Choose a reason for hiding this comment

JumiDeluxe Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Oct 29, 2024

Diff report

modular-magician commented Oct 29, 2024

Tests analytics

Action taken

modular-magician commented Oct 29, 2024

Tests analytics

Action taken

modular-magician commented Oct 29, 2024

modular-magician commented Oct 29, 2024

modular-magician commented Nov 13, 2024

Diff report

Missing test report

modular-magician commented Nov 13, 2024

Tests analytics

Action taken

modular-magician commented Nov 13, 2024

modular-magician commented Nov 13, 2024

Diff report

Missing test report

modular-magician commented Nov 13, 2024

Tests analytics

Action taken

modular-magician commented Nov 13, 2024

modular-magician commented Nov 13, 2024

Diff report

Missing test report

modular-magician commented Nov 13, 2024

Tests analytics

Action taken

modular-magician commented Nov 13, 2024

modular-magician commented Nov 13, 2024

Diff report

JumiDeluxe commented Oct 29, 2024 •

edited

Loading

JumiDeluxe Oct 29, 2024 •

edited

Loading

JumiDeluxe commented Dec 3, 2024 •

edited

Loading