Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add new resource for creating Whistle Mapping, Reconciliation and Backfill Pipeline Jobs for Healthcare Data Engine " #11776

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Sep 20, 2024

Reverts #11677

This resource should go in the private provider for now. See go/terraform-eap

`google_healthcare_pipeline_job` (revert)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2 insertions(+), 2024 deletions(-))
google-beta provider: Diff ( 4 files changed, 2 insertions(+), 2024 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_healthcare_pipeline_job was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 40
Passed tests: 40
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 added the override-breaking-change Allows a potential breaking change to be merged label Sep 20, 2024
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trodge trodge merged commit 9c53391 into main Sep 20, 2024
12 of 15 checks passed
@trodge trodge deleted the revert-11677-main branch September 20, 2024 21:04
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/healthcare
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants