Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote the Port Mapping NEG from Beta to GA #11771

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

Cheriit
Copy link
Contributor

@Cheriit Cheriit commented Sep 20, 2024

Promote the PSC Port Mapping NEG functionality from Beta to GA

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 227 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 15 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 120 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1007
Passed tests: 933
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPortmapExample
  • TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample
    $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 221 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 4 insertions(+), 22 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 120 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1007
Passed tests: 932
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages
  • compute
#### Non-exercised tests

Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPortmapExample
  • TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointPortmapExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@Cheriit Cheriit marked this pull request as ready for review September 20, 2024 11:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@BBBmau BBBmau merged commit 7ffced3 into GoogleCloudPlatform:main Sep 23, 2024
14 checks passed
@ScottSuarez
Copy link
Contributor

@BBBmau , just check in. Since this promotes to GA were you able to run the GA tests locally to confirm they pass?

@melinath
Copy link
Member

melinath commented Sep 27, 2024

@ScottSuarez @roaks3 FYI this may need a revert (& cherry-pick?) - b/369737633
has more details. #11854 has the revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants