Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildServiceAccount field to cloudfunctions #11100

Merged

Conversation

nifflets
Copy link
Contributor

@nifflets nifflets commented Jul 2, 2024

Adding support for the buildServiceAccount field in cloudfunctions as it has recently been released to GA.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: added `build_service_account` field to `google_cloudfunctions_function` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 117 insertions(+))
google-beta provider: Diff ( 2 files changed, 117 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 117 insertions(+))
google-beta provider: Diff ( 2 files changed, 117 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_buildServiceAccount

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_buildServiceAccount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_buildServiceAccount[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_buildServiceAccount[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@nifflets nifflets force-pushed the cloudfunctions-buildserviceaccount branch from 1f27296 to c36af3b Compare July 3, 2024 20:13
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+))
google-beta provider: Diff ( 2 files changed, 131 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  build_service_account = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_buildServiceAccount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_buildServiceAccount[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@nifflets nifflets force-pushed the cloudfunctions-buildserviceaccount branch from c36af3b to f79f3ce Compare July 3, 2024 22:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+))
google-beta provider: Diff ( 2 files changed, 131 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  build_service_account = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_buildServiceAccount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_buildServiceAccount[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@nifflets nifflets marked this pull request as ready for review July 3, 2024 22:54
@github-actions github-actions bot requested a review from c2thorn July 3, 2024 22:54
Copy link

github-actions bot commented Jul 3, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

github-actions bot commented Jul 8, 2024

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nifflets nifflets force-pushed the cloudfunctions-buildserviceaccount branch from f79f3ce to 44fb131 Compare July 9, 2024 20:19
@github-actions github-actions bot requested a review from c2thorn July 9, 2024 20:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 134 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudfunctions_function (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudfunctions_function" "primary" {
  build_service_account = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@nifflets
Copy link
Contributor Author

nifflets commented Jul 9, 2024

@c2thorn c2thorn merged commit a1b89f3 into GoogleCloudPlatform:main Jul 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants