Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemini Code Assist for Google Cloud resources #12181

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JumiDeluxe
Copy link
Member

@JumiDeluxe JumiDeluxe commented Oct 29, 2024

Add new resources for Gemini Code Assist

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_gemini_code_repository_index`
`google_gemini_repository_group`

@github-actions github-actions bot requested a review from BBBmau October 29, 2024 13:54
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_geminifor_google_cloud_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_geminifor_google_cloud_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_repository_group" "primary" {
  labels = # value needed
}

# limitations under the License.

---
name: GeminiforGoogleCloud
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other examples, this should be just "Gemini"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also worth sharing that with this being a new service you'll want include it in the list of teamcity services which is mentioned in the failing teamcity diff check: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/11576174691/job/32224494242?pr=12181

You'll also need to include cloudaicompanion.googleapis.com as part of the services that our CI has which is done here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/infra/terraform/main.tf

An example of a service being added can be found here. This will need to be done in a separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified to Gemini.
I've included the cloudaicompanion.googleapis.com service in the #12186 PR.
Teamcity services also added for GA and beta.

@@ -0,0 +1,4 @@
resource "google_geminifor_google_cloud_code_repository_index" "example_cri" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awkward. If my understanding is correct, the prefix is taken from product.yaml name field. After you update the name, I expect the resource to be "google_gemini_code_repository_index"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name simplification shortened resources names to google_gemini_repository_group and google_gemini_code_repository_index. Updating the issue description

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 7210cb2 to 67544d1 Compare October 29, 2024 14:36
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_geminifor_google_cloud_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_geminifor_google_cloud_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_geminifor_google_cloud_repository_group" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4222
Passed tests: 3796
Skipped tests: 421
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceConfidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccContainerCluster_resourceManagerTags
  • TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample
  • TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_resourceManagerTags [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4222
Passed tests: 3797
Skipped tests: 421
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceConfidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample
  • TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccGeminiforGoogleCloudCodeRepositoryIndex_geminiforGoogleCloudCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiforGoogleCloudRepositoryGroup_geminiforGoogleCloudRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 23487f1 to 9376ec2 Compare October 29, 2024 19:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

3 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2023 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 16 files changed, 2013 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_code_repository_index (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_code_repository_index" "primary" {
  kms_key = # value needed
  labels  = # value needed
}

Resource: google_gemini_repository_group (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_repository_group" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 20 files changed, 2177 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 18 files changed, 2167 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

@@ -141,6 +141,11 @@ var ServicesListGa = mapOf(
"displayName" to "Certificatemanager",
"path" to "./google/services/certificatemanager"
),
"gemini" to mapOf(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the service name should be cloudaicompanion and not gemini since the service is cloudaicompanion.

Copy link
Member Author

@JumiDeluxe JumiDeluxe Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the teamcity service name change commit.
Hm, the teamcity-services-diff-check is also looking for the gemini service. Should we add a duplicate entry pointing at the cloudaicompanion path? I wonder how it is determined, since it wants the service to be mapped under both names.

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 10c3aa0 to 9b6320e Compare October 29, 2024 20:43
@github-actions github-actions bot requested a review from BBBmau October 29, 2024 20:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 20 files changed, 2177 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 18 files changed, 2167 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 205 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 220 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4226
Passed tests: 3804
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4226
Passed tests: 3804
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4290
Passed tests: 3856
Skipped tests: 419
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_resourceManagerTags
  • TestAccContainerCluster_withFleetConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4290
Passed tests: 3856
Skipped tests: 419
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_resourceManagerTags
  • TestAccContainerCluster_withFleetConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupPlanAssociation_backupDrBpaExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupPlanAssociation_backupDrBpaExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccContainerCluster_resourceManagerTags [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4290
Passed tests: 3851
Skipped tests: 419
Affected tests: 20

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlanAssociation_backupDrBpaExample
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_resourceManagerTags
  • TestAccContainerCluster_withFleetConfig
  • TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccSpannerInstance_basic
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupPlanAssociation_backupDrBpaExample [Debug log]
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccContainerCluster_resourceManagerTags [Debug log]
TestAccDataSourceGoogleBackupDRBackupPlanAssociation_basic [Debug log]
TestAccSpannerInstance_basic [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 54e2a4f to abaef65 Compare November 8, 2024 19:42
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4102 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4296
Passed tests: 3864
Skipped tests: 415
Affected tests: 17

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccContainerCluster_withFleetConfig
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccGeminiRepositoryGroup_update
  • TestAccSpannerInstance_basic
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig
  • TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSpannerInstance_basic [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingNodeConfigUpdate [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfig [Debug log]
TestAccSpannerInstance_basicWithAutoscalingUsingProcessingUnitConfigUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from abaef65 to c3f9677 Compare November 12, 2024 15:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4102 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4301
Passed tests: 3876
Skipped tests: 412
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_withFleetConfig
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccGeminiRepositoryGroup_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4102 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4304
Passed tests: 3881
Skipped tests: 412
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccContainerCluster_withFleetConfig
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccGeminiRepositoryGroup_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from b118abe to c85e0ec Compare November 12, 2024 21:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4102 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4303
Passed tests: 3878
Skipped tests: 412
Affected tests: 13

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccComputeFirewallPolicyAssociation_basic
  • TestAccContainerCluster_withFleetConfig
  • TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccGeminiRepositoryGroup_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]
TestAccGeminiCodeRepositoryIndex_geminiCodeRepositoryIndexBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from c85e0ec to 03492df Compare November 13, 2024 00:16
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4100 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4304
Passed tests: 3880
Skipped tests: 412
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGeminiRepositoryGroupIamBindingGenerated_withAndWithoutCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withAndWithoutCondition

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccContainerCluster_withFleetConfig
  • TestAccGeminiCodeRepositoryIndex_update
  • TestAccGeminiRepositoryGroupIamBindingGenerated
  • TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamMemberGenerated
  • TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition
  • TestAccGeminiRepositoryGroupIamPolicyGenerated
  • TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition
  • TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample
  • TestAccGeminiRepositoryGroup_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBackupDRBackupPlan_backupDrBackupPlanSimpleExample [Error message] [Debug log]
TestAccContainerCluster_withFleetConfig [Error message] [Debug log]
TestAccGeminiCodeRepositoryIndex_update [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamBindingGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamMemberGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated [Error message] [Debug log]
TestAccGeminiRepositoryGroupIamPolicyGenerated_withCondition [Error message] [Debug log]
TestAccGeminiRepositoryGroup_geminiRepositoryGroupBasicExample [Error message] [Debug log]
TestAccGeminiRepositoryGroup_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@JumiDeluxe JumiDeluxe force-pushed the gemini-for-google-cloud-provider branch from 03492df to 88fbf9b Compare November 13, 2024 11:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 643 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 26 files changed, 4101 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 599 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants