Set CGO_ENABLED=0 for the whole build to be set on all go commands #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
briandealwis
requested changes
Jun 16, 2023
There was a problem hiding this comment.
Could you put a comment before each occurrence to link to the issue explaining the problem?
Or alternatively could just say something like avoid dynamic linking of libc.
And two other changes:
- since we’re not linking against libc then we can use the
staticimages - distroless now publishes distribution tags (
static-debian11)
See example here.
|
/gcbrun |
|
/gcbrun |
iennae
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
LGTM
ref doc for image change - https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md
static is the right one for use with Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1248, we are still seeing some breakages on the
go mod download. This sets the variable for the whole build so any call togowill get the option.