[rootkiller6788]

list -s <url> never found any agents.

fetch_remote_template hands back (template_dir, temp_dir), and list.py read the tuple the other way round, so the scan got pointed at the temp root of the clone instead of the template dir inside it. For adk-samples that root has no python/agents/, so this is what you get:

$ agent-starter-pack list -s https://github.com/google/adk-samples
Fetching agents from https://github.com/google/adk-samples...
No agents found in https://github.com/google/adk-samples

while list --adk on the very same repo lists them fine. Same for any remote source with a sub-path, e.g. -s google/adk-samples/python/agents/data-science.

Fix is to use the first element of the tuple. The scan_from_root flag goes away with it: when the spec has no sub-path template_dir already is the clone root, which is all that flag did, and --adk was its only caller.

While in there I noticed list never removes the temp clone (create does), so every list -s / list --adk left a copy of the repo behind in /tmp. It's dropped in a finally now.

Added a test that mocks the fetch against a fake clone and checks the agents show up and the temp dir is gone. It fails on the current code.

[gemini-code-assist]

Code Review

This pull request refactors the remote agent listing functionality to ensure that the temporary repository clone is properly cleaned up after use. It updates list_remote_agents to retrieve both the template directory and the temporary clone root from fetch_remote_template, utilizing a finally block with shutil.rmtree to clean up the clone. A new test is also added to verify this behavior. The review feedback suggests keeping the tracking variable as a pathlib.Path object and passing it directly to shutil.rmtree instead of converting it to a string, which simplifies the code and maintains type consistency.