Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: Use jdbc connection properties for reverse migration #2198

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta changed the title fix: Use jdbc connection properties for reverse migration bug-fix: Use jdbc connection properties for reverse migration Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (7b7081b) to head (9509b1a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...lates/dbutils/connection/JdbcConnectionHelper.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2198      +/-   ##
============================================
+ Coverage     47.06%   47.19%   +0.12%     
- Complexity     4376     4382       +6     
============================================
  Files           876      876              
  Lines         52218    52324     +106     
  Branches       5505     5521      +16     
============================================
+ Hits          24578    24692     +114     
+ Misses        25881    25875       -6     
+ Partials       1759     1757       -2     
Components Coverage Δ
spanner-templates 69.18% <0.00%> (+0.24%) ⬆️
spanner-import-export 65.75% <ø> (+0.01%) ⬆️
spanner-live-forward-migration 77.30% <ø> (+0.76%) ⬆️
spanner-live-reverse-replication 79.50% <0.00%> (+0.70%) ⬆️
spanner-bulk-migration 88.32% <ø> (+0.37%) ⬆️
Files with missing lines Coverage Δ
...lates/dbutils/connection/JdbcConnectionHelper.java 35.41% <0.00%> (+2.76%) ⬆️

... and 12 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant