Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AvroToValueMapper (Spanner writer) for non-primitive types #2175

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

VardhanThigle
Copy link
Contributor

@VardhanThigle VardhanThigle commented Feb 12, 2025

TODO:

  1. Handling of Maps as Json
  2. Filling Array in JSON node and handling in changeEventType convert will be covered as a part b/390535288

@VardhanThigle VardhanThigle marked this pull request as ready for review February 12, 2025 04:36
@VardhanThigle VardhanThigle requested a review from a team as a code owner February 12, 2025 04:36
@VardhanThigle VardhanThigle marked this pull request as draft February 12, 2025 04:36
@VardhanThigle VardhanThigle changed the title [DRAFT] Adding AvroToValueMapper for array types [DRAFT- not for review] Adding AvroToValueMapper for array types Feb 12, 2025
@VardhanThigle VardhanThigle force-pushed the cassandra branch 3 times, most recently from a344b69 to 0b05562 Compare February 12, 2025 05:01
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (b51c933) to head (4c53d8b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2175      +/-   ##
============================================
+ Coverage     47.05%   55.58%   +8.53%     
+ Complexity     4049     1642    -2407     
============================================
  Files           876      409     -467     
  Lines         52230    22305   -29925     
  Branches       5507     2217    -3290     
============================================
- Hits          24578    12399   -12179     
+ Misses        25892     9192   -16700     
+ Partials       1760      714    -1046     
Components Coverage Δ
spanner-templates 70.76% <100.00%> (+1.84%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 77.30% <100.00%> (+0.81%) ⬆️
spanner-live-reverse-replication 79.47% <100.00%> (+0.66%) ⬆️
spanner-bulk-migration 88.32% <100.00%> (+0.37%) ⬆️
Files with missing lines Coverage Δ
.../cassandra/mappings/CassandraMappingsProvider.java 98.11% <100.00%> (ø)
...sandra/rowmapper/CassandraRowValueArrayMapper.java 100.00% <100.00%> (ø)
.../v2/spanner/migrations/avro/AvroToValueMapper.java 94.17% <100.00%> (+2.99%) ⬆️
...er/migrations/avro/GenericRecordTypeConvertor.java 95.73% <100.00%> (+2.08%) ⬆️

... and 485 files with indirect coverage changes

@VardhanThigle VardhanThigle force-pushed the cassandra branch 2 times, most recently from 3f90440 to 75682df Compare February 12, 2025 11:06
@VardhanThigle VardhanThigle changed the title [DRAFT- not for review] Adding AvroToValueMapper for array types [DRAFT- not for review] Adding AvroToValueMapper (Spanner writer) for non-primitive types Feb 13, 2025
@VardhanThigle VardhanThigle force-pushed the cassandra branch 11 times, most recently from 01a4a30 to 671d79c Compare February 19, 2025 15:04
@VardhanThigle VardhanThigle marked this pull request as ready for review February 20, 2025 04:28
@VardhanThigle VardhanThigle changed the title [DRAFT- not for review] Adding AvroToValueMapper (Spanner writer) for non-primitive types Adding AvroToValueMapper (Spanner writer) for non-primitive types Feb 20, 2025
Copy link
Contributor

@shreyakhajanchi shreyakhajanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VardhanThigle VardhanThigle merged commit ae6134f into GoogleCloudPlatform:main Feb 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants