-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues for sequences and identity columns #2171
Fix issues for sequences and identity columns #2171
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
============================================
+ Coverage 46.95% 47.06% +0.10%
- Complexity 4044 4053 +9
============================================
Files 876 876
Lines 52190 52226 +36
Branches 5501 5508 +7
============================================
+ Hits 24507 24580 +73
+ Misses 25924 25887 -37
Partials 1759 1759
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darshan-sj Do we also test this functionality in an IT? Do we need to update a corresponding IT as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check ExportPipelineIT and ImportPipelineIT and please add a test case if it is possible to add for this edgecase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix a few issues related to sequences and identity columns:
null
strings appear in identity columns. If a parameter is null, it should not appear in the output file.BIT_REVERSED_POSITIVE_SEQUENCE
tobit_reversed_positive
because theidentity_kind
in the information_schema table has a valueBIT_REVERSED_POSITIVE_SEQUENCE
which is different thanbit_reversed_positive
.sequence_kind="default"
is not shown properly for the statementCREATE SEQUENCE myseq
.