[Build] Remove sudo from prebuild script and harden GitHub Actions workflows - #172
Merged
Merged
Conversation
Do not invoke sudo when cleaning the local build directory in the diagnostics-extension npm prebuild lifecycle hook.
Pin actions/checkout, actions/setup-node, and codecov/codecov-action to immutable v4 commit SHAs and declare explicit read-only contents permissions in CI workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudofromprebuildscript (diagnostics-extension/package.json):"prebuild": "sudo rm -rf build/"with"prebuild": "rm -rf build/"so cleaning the local build directory does not request root privileges duringnpm run build/npm run dev..github/workflows/angular.test.yml,.github/workflows/extension.test.yml):actions/checkout,actions/setup-node, andcodecov/codecov-actionto immutablev440-character commit SHAs.permissions: contents: readto restrictGITHUB_TOKENto read-only repository access.Testing
npm run script:ciindiagnostics-extension(webpackbuild,tsc,jest36/36 unit tests, andgts lintpassing)