Prefer features without location condition
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action.openPopup() API is available to policy installed extensions, OR to any extension as long as a (default enabled) feature flag is set. We can't render complex unions like this so instead just prefer the result without the `location` condition. The result of this is that openPopup() will show as available on stable without the "Requires policy" badge / TypeScript comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 44.31% 44.40% +0.09%
==========================================
Files 21 21
Lines 4069 4076 +7
Branches 282 284 +2
==========================================
+ Hits 1803 1810 +7
Misses 2266 2266 ☔ View full report in Codecov by Sentry. |
patrickkettner
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally had this change in #73, but then I thought it wasn't needed any more so removed it. Unfortunately the build is still failing and this should hopefully fix that: https://github.com/GoogleChrome/chrome-types/actions/runs/9392019690/job/25865438994#step:6:13862