Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore incorrect nodoc in Chrome 111+ for world parameter #70

Merged
merged 1 commit into from
May 23, 2024

Conversation

oliverdunk
Copy link
Member

This type was added in Chrome 102 and implemented in Chrome 111. However, it is still marked as nodoc.

I have opened a CL to remove the nodoc but we need to manually fix the versioning information.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.30%. Comparing base (180c029) to head (08cd3e7).

Files Patch % Lines
tools/render-symbols.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main      #70       +/-   ##
=========================================
+ Coverage      0   44.30%   +44.30%     
=========================================
  Files         0       21       +21     
  Lines         0     4063     +4063     
  Branches      0      281      +281     
=========================================
+ Hits          0     1800     +1800     
- Misses        0     2263     +2263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@patrickkettner patrickkettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliverdunk oliverdunk merged commit 52e3a1c into main May 23, 2024
5 of 6 checks passed
@oliverdunk oliverdunk deleted the nodoc-world-fix branch May 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants