Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Vote author promote improve #1356 and tests #1355 #1357

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Vote author promote improve #1356 and tests #1355 #1357

merged 3 commits into from
Jul 24, 2019

Conversation

maslenitsa93
Copy link

Resolves #1356:

  • Now it doesn't cuts from voter claim + voter auction reward, but cuts only from voter claim. I think it is more logically because voter allowed cutting only his voter claim, also it doesn't complicates calculation of voter auction reward.

Resolves #1355:

  • Added tests on vote_options operation.
  • Added tests on author_promote_rate extension of this operation. (Future extensions to vote_options-operation also will be separated test cases.)

@maslenitsa93 maslenitsa93 added this to the 0.22.0 milestone Jul 24, 2019
@maslenitsa93 maslenitsa93 requested a review from afalaleev July 24, 2019 06:06
@maslenitsa93 maslenitsa93 self-assigned this Jul 24, 2019
@afalaleev afalaleev merged commit be5a552 into golos-v0.22.0 Jul 24, 2019
@afalaleev afalaleev deleted the vote-author-promote-improve-and-tests branch July 24, 2019 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afalaleev afalaleev afalaleev approved these changes

Assignees

@maslenitsa93 maslenitsa93

Labels
hardfork tests
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maslenitsa93 @afalaleev