feat: ensure a11y ARIA compliance for loading_spinner_skeleton (#273) - #386
Merged
godamongstmen897 merged 2 commits intoSep 1, 2026
Merged
Conversation
…i-locks#273) - Add aria-busy to advertise the in-progress loading state - Add motion-reduce variants to disable pulse/fade animations - Preserve role=status, aria-live, sr-only message, and keyboard support - Add tests covering ARIA semantics, reduced motion, and keyboard nav
|
@Junirezz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
Summary
Audited and strengthened the
LoadingSkeletoncomponent's ARIA compliance and accessibility.Changes
aria-busy="true"to advertise the in-progress loading state to assistive technology (role="status"+aria-live="polite"retained on the default variant)motion-reduce:animate-noneandmotion-reduce:transition-noneso the pulse/fade animations are disabled underprefers-reduced-motiontabindex=-1)aria-hidden="true"visual skeleton and thesr-onlyaccessible loading messageVerification
__tests__/loading-skeleton-a11y.test.tsx(15 tests) covering ARIA semantics, reduced-motion compliance, keyboard navigability, accessible names, and color-contrast tokens