Feat: Dispute Raise ModaL - #355
Merged
godamongstmen897 merged 37 commits intoAug 31, 2026
Merged
Conversation
- Replace hardcoded empty message with EmptyStateCard component - Display briefcase icon for job-related context - Show descriptive title and explanation text - Include role badges (Client, Freelancer, Arbiter) showing available participation options - Add comprehensive test coverage with 16 test cases - Ensure proper accessibility with region landmarks and aria-labels - Validates placeholder display under empty data states
|
@She-ge Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…handled rejections
- vitest.config.mts: inline @stellar/freighter-api + @creit.tech/stellar-wallets-kit
so Vite (not Node) does the CJS->ESM interop. Node's named-export detection on
freighter-api's minified UMD bundle only yields {default, freighterApi}, so the
kit's 'import { getAddress }' threw a SyntaxError that killed every suite
importing app/context/WalletContext.tsx.
- freighter_multisig_hook.test.ts: replace base64('aaaa...') fixtures with real
signed testnet envelopes built via TransactionBuilder.
- signature_timeout_alert_timeout.test.ts: attach rejection handlers before
advancing fake timers so Node's unhandled-rejection sweep does not fire.
- signature_timeout_alert.test.tsx: await the loader overlay instead of querying
synchronously after a React state update.
- SignatureTimeoutAlert.tsx: remove the dangling expression left behind by the
useMemo refactor.
…allet-disconnect-handler-Goldii-locks#242-FIX
…allet-disconnect-handler-Goldii-locks#242-FIX
…allet-disconnect-handler-Goldii-locks#242-FIX
The PR imported EmptyStateCard but never added the component, so the dashboard would not build. Added it, satisfying this PR's contract (dashboard-empty-state test id, region role with an aria-label, an SVG briefcase icon and role badges) while also carrying the shared empty-state/-title/-description ids the existing dashboard empty-state test queries. The description now carries both wordings so the existing assertion (/create one to get started/i) and this PR's fuller copy both hold.
…allet-disconnect-handler-Goldii-locks#242-FIX
…y-state-ui feat: implement descriptive empty state UI for dashboard jobs list
…torybook-318 Build Storybook interface mocks for dark_mode_switcher
The branch was pushed with a botched conflict resolution: the `>>>>>>>` markers were stripped but the branch-name lines and both sides of each conflict were left in place. That left four stray `Write-React-Testing-Library-assertions-...-Goldii-locks#242-FIX` lines, a duplicate `@stellar/stellar-sdk` import block, a second `parseMessage` useMemo in SignatureTimeoutAlert, and a duplicate `server` key in vitest.config.mts. Resolved by taking main for the five files the branch only touched incidentally -- main already carries the equivalent, deduplicated work (the same parseMessage useMemo derivation and the same freighter-api inline config the branch was re-adding). The branch's actual deliverable for Goldii-locks#242 is kept intact: WALLET_DISCONNECT_HANDLER_TESTS.md and the 851-line wallet_disconnect_handler.component.test.ts. lint 0 errors / tsc 0 errors / 1776 tests passing / build OK
…Testing-Library-assertions-for-wallet-disconnect-handler-#242-FIX Write React Testing Library assertions for wallet disconnect handler …
…ns target The two design-token cases rendered WalletSelectorModal with its default props, where `errorMessage` defaults to null and `activeAddress` defaults to null. Both surfaces under test are gated on those props, so `wallet-selector-error-message` and `wallet-selector-connected-badge` were never in the tree and the queries threw. Passed an errorMessage to the first case and an activeAddress to the second. The component's design tokens were already correct -- only the test setup needed the props. lint 0 errors / tsc 0 errors / 1778 tests passing / build OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #337