Skip to content

fix(signature-timeout-alert): derive parse message with useMemo instead of setState-in-effect #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 31, 2026
Merged

fix(signature-timeout-alert): derive parse message with useMemo instead of setState-in-effect #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions app/components/SignatureTimeoutAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";

import { useEffect, useState } from "react";
import { useEffect, useMemo, useState } from "react";
import { useWallet } from "@/app/context/WalletContext";
import { NETWORK_PASSPHRASE } from "@/app/lib/contract";
import {
Expand Down Expand Up @@ -50,7 +50,6 @@ export default function SignatureTimeoutAlert({
const albedoAssembly = useAlbedoMultiSigAssembly(NETWORK_PASSPHRASE);
const ledgerAssembly = useLedgerMultiSigAssembly(NETWORK_PASSPHRASE);
const [isRetrying, setIsRetrying] = useState(false);
const [parseMessage, setParseMessage] = useState<string | null>(null);

const activeError = error ?? signatureTimeoutError;
const activeTransactionXdr = transactionXdr ?? signatureTimeoutXdr ?? undefined;
Expand All @@ -69,21 +68,16 @@ export default function SignatureTimeoutAlert({
});
}, [activeError, hasTimeout, networkMismatchMessage, transactionId]);

useEffect(() => {
if (!activeTransactionXdr) {
setParseMessage(null);
return;
}
const parseMessage = useMemo(() => {
if (!activeTransactionXdr) return null;

try {
parseMultiSigEnvelope(activeTransactionXdr, {
parseEnvelopeXdr: createStellarEnvelopeParser(NETWORK_PASSPHRASE),
});
setParseMessage(null);
return null;
} catch (parseError) {
setParseMessage(
parseError instanceof Error ? parseError.message : String(parseError)
);
return parseError instanceof Error ? parseError.message : String(parseError);
}
}, [activeTransactionXdr]);

Expand Down