fix: repair milestone-escrow CI build and tests - #429
Open
iexwr wants to merge 1 commit into
Open
Conversation
- annotate test modules with #[cfg(test)] so the wasm build succeeds without dev-dependencies - make setup_funded_escrow pub(crate) and fix test imports so sibling test modules can use it (Address::generate requires testutils trait) - remove redundant admin.require_auth() before require_admin in admin_override_cancel_refund; require_admin already performs the signature check, and env-host 22.1.3 rejects the double auth with Error(Auth, ExistingValue) - fund a terminal-state cancel test through the zero-balance boundary guard in cancel_escrow so its invalid-amount assertion stays intact - add missing admin_override_cancel_tests snapshot files (untracked, would otherwise fail CI on a fresh checkout)
|
Hey @iexwr! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the repo-wide CI failure so the test suite builds and runs again on a clean checkout.
Root causes fixed
#[cfg(test)]incontracts/milestone-escrow/src/lib.rs. Without it, dev-dependencies were referenced during thewasm32build, failing CI compilation.setup_funded_escrowwas private andAddress::generateneededsoroban_sdk::testutils::Address, soadmin_override_cancel_tests.rscould not compile as a sibling module.admin_override_cancel_refund: calledadmin.require_auth()thenrequire_admin(which also callsadmin.require_auth()). env-host 22.1.3 rejects the nested frame withError(Auth, ExistingValue), failing 8 tests.admin_override_cancel_tests(untracked in main), which fail CI on a fresh checkout.Validation
cargo testformilestone-escrow: 463 passed, 0 failed.