Skip to content

perf(cancel): compact escrow lock storage key - #358

Open
Beneaththesky001 wants to merge 4 commits into
Goldii-locks:mainfrom
Beneaththesky001:fix/issue-296
Open

perf(cancel): compact escrow lock storage key#358
Beneaththesky001 wants to merge 4 commits into
Goldii-locks:mainfrom
Beneaththesky001:fix/issue-296

Conversation

@Beneaththesky001

@Beneaththesky001 Beneaththesky001 commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • replace the verbose CancelLock instance-storage key with compact C
  • preserve cancel-lock enforcement across normal operations and admin overrides
  • add regression coverage for the compact key and locked-state behavior

Closes #296

Verification

  • cargo fmt --all -- --check
  • cargo test -p milestone-escrow (312 passed)

Fixes #296

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Beneaththesky001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@godamongstmen897

Copy link
Copy Markdown
Contributor

@Beneaththesky001 FIX FAILED CI

@Beneaththesky001

Copy link
Copy Markdown
Author

@Goldii-locks @Beneaththesky001 Status update for #296: pushed commit 1b1a32f aligning all cancel-lock accesses with upstream CancelLock; cargo test compiled 427 tests and passed 425, with 2 existing tax-withholding failures. Please review the linked CI result and rerun checks where applicable.

@Beneaththesky001

Copy link
Copy Markdown
Author

@Goldii-locks @Beneaththesky001 PR #358 references Fixes #296. Please review/rerun CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize storage keys footprint for cancel_escrow

3 participants