perf(cancel): compact escrow lock storage key - #358
Open
Beneaththesky001 wants to merge 4 commits into
Open
Conversation
|
@Beneaththesky001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Beneaththesky001 FIX FAILED CI |
Author
|
@Goldii-locks @Beneaththesky001 Status update for #296: pushed commit 1b1a32f aligning all cancel-lock accesses with upstream CancelLock; cargo test compiled 427 tests and passed 425, with 2 existing tax-withholding failures. Please review the linked CI result and rerun checks where applicable. |
Author
|
@Goldii-locks @Beneaththesky001 PR #358 references Fixes #296. Please review/rerun CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancelLockinstance-storage key with compactCCloses #296
Verification
cargo fmt --all -- --checkcargo test -p milestone-escrow(312 passed)Fixes #296