fix(jobs): integrate zod schema middleware with validateWithFields in… - #383
Closed
Davoski1 wants to merge 1 commit into
Closed
fix(jobs): integrate zod schema middleware with validateWithFields in…#383Davoski1 wants to merge 1 commit into
Davoski1 wants to merge 1 commit into
Conversation
… partial-release route (Issue Goldii-locks#115)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #115
This PR integrates Zod request shape validations as a reusable middleware handler for the
POST /api/jobs/:contractId/milestones/:index/partial-releaseroute, enabling detailed field-level validation errors.Changes Made
validatemiddleware withvalidateWithFieldsfor thepartialReleaseBodySchemainsidesrc/routes/jobs.ts. This ensures that invalid request shapes are parsed and reported back with afieldsmapping (e.g.,fields: { amount: "..." }) rather than just a generic array of error details.__tests__/partial-release.test.tsto assert that the newfieldsproperty is correctly returned in the JSON response payload for invalid formats (e.g. invalidamountorsourceAddress).Verification
partial-releaseendpoint pass successfully.