test: implement indexer_runner transaction isolation validation (#185) - #382
Closed
Davoski1 wants to merge 1 commit into
Closed
test: implement indexer_runner transaction isolation validation (#185)#382Davoski1 wants to merge 1 commit into
Davoski1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #185
This PR addresses the requirement to ensure that
indexer_runneroperations run inside SQLite transaction blocks to protect data consistency under load.During investigation, we confirmed that the primary write path for the main indexer event poller execution loop (
insertEventBatchcalled frompollEvents) is already safely wrapped in a strict synchronousdb.transaction()block provided bybetter-sqlite3.To fulfill the issue's validation and testing requirements, this PR focuses on formally proving this transactional safety by introducing explicit test coverage that asserts the rollback behavior.
Changes Included
__tests__/indexer-runner-transaction.test.tsto validate transaction isolation during polling.last_ledger_sequencepointer does not advance (i.e., verifying that partial database updates rollback fully on execution failures).Testing & Verification
Checklist