Continuation of @wow4201's Item Frames #514
Conversation
|
Awesome, thanks for continuing this. Also that's an awful lot of checkstyle fixups. |
|
Cool, great to see my code didn't go to waste. It's 100% function same as Mojang code. However the API part might need some work. |
|
Oh shit @wow4201 is alive and I was criticising his code with no filter just now. Sorry for that! |
|
@wow4201: Are you interesting in continuing your chest sounds/animation PR, or can I take it over? |
|
I did some work on that one: https://github.com/dequis/Glowstone/compare/pr-211 - Main issue is that it needs some un-copypasting. Also, I don't remember the details (see old PR), but the 'bindchest' concept might be debatable. |
|
@Aaron1011 feel free, I love to contribute my code to this project, I'm just not good at dealing with teams. |
Aaron1011
force-pushed
the
ITEM_FRAME_18
branch
from
5dcef2e to
3303c55
Compare
|
|
|
@Aaron1011 This PR has been associated with GlowstoneMC/Glowkit#52 - |
Aaron1011
force-pushed
the
ITEM_FRAME_18
branch
from
1350937 to
26344c5
Compare
There was a problem hiding this comment.
this is the only change in the whole file, drop it
Aaron1011
changed the title
|
@Aaron1011 This also fires the event twice per interact. |
There was a problem hiding this comment.
What is the purpose of setting AIR_TIME here?
There was a problem hiding this comment.
Sorry, that was left in by @wow4201. I'll remove it.
|
@Aaron1011 Head's up, this is broken thanks to master. |
Aaron1011
force-pushed
the
ITEM_FRAME_18
branch
from
a64756d to
08c652b
Compare
#514 Conflicts: src/main/java/net/glowstone/entity/GlowEntity.java
…nstead of doubles Modification to: #514 Continuation of @wow4201's Item Frames instead of taking the Glowkit change to add getRotationAngle() etc.: https://github.com/GlowstoneMC/Glowkit/pull/52 Add degree-based rotations change the implementation to use new rotation values in the enum: GlowstonePlusPlus/Glowkit-Legacy@b6c156d Support the new Rotation values.
|
@SpaceManiac This pull request is still pending pull. The pull request has been re-tested and is confirmed to be operational. |
6 participants
This is a continuation of Item Frames support, started by @wow4201.
I've made some checkstyle fixes, and prevented item from being removed from a player inventory in Creative.
Glowkit: https://github.com/GlowstoneMC/Glowkit/pull/52
@wow4201: If you decide to pick this up again, I'll close this PR and give all the code to you.