Skip to content

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Jun 3, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Based On #2094
Add expand charts dashboard

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.43%. Comparing base (1f7617c) to head (dc101fe).

Files with missing lines Patch % Lines
...r/lib/device/device.getDeviceFeaturesAggregates.js 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
- Coverage   98.48%   98.43%   -0.05%     
==========================================
  Files         867      867              
  Lines       14182    14193      +11     
==========================================
+ Hits        13967    13971       +4     
- Misses        215      222       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jun 3, 2024

#2755 Bundle Size — 10.28MiB (+0.41%).

1de3752(current) vs 2b8e274 master#2753(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2755
     Baseline
#2753
Regression  Initial JS 5.58MiB(+0.73%) 5.54MiB
Regression  Initial CSS 306.06KiB(+0.47%) 304.63KiB
Change  Cache Invalidation 66.27% 0%
No change  Chunks 51 51
No change  Assets 171 171
Change  Modules 1494(+0.13%) 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2755
     Baseline
#2753
Regression  JS 7.37MiB (+0.56%) 7.32MiB
No change  IMG 2.48MiB 2.48MiB
Regression  CSS 322.85KiB (+0.44%) 321.42KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:add-zoom-charts-dashboa...Project dashboard


Generated by RelativeCIDocumentationReport issue

Terdious and others added 25 commits June 3, 2024 22:30
@Terdious Terdious force-pushed the add-zoom-charts-dashboard branch from 97cf68c to ec8e8bc Compare September 4, 2024 13:51
Copy link

stale bot commented Dec 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 8, 2024
@stale stale bot closed this Dec 18, 2024
@Terdious Terdious reopened this Jun 25, 2025
@stale stale bot removed the stale label Jun 25, 2025
Copy link

stale bot commented Aug 24, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 24, 2025
@stale stale bot closed this Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant