Adding a reference from the email flagging to the subscribe flagging.#117
Open
kevin-dutra wants to merge 3 commits into
Open
Adding a reference from the email flagging to the subscribe flagging.#117kevin-dutra wants to merge 3 commits into
kevin-dutra wants to merge 3 commits into
Conversation
Contributor
|
I think the tests need updating. If when you get around to this, I'm trying to move future development back to drupal.org, so please open the issue there so I'll see it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing currently ties the "subscribe" flagging directly to the "email" flagging, which makes Views relationships between the two not possible out of the box. This adds an actual reference to the "email" flagging.
IMPORTANT: This is not ready for merge yet. It's written with the assumption that the work from (https://www.drupal.org/node/2678756) has been incorporated, so this will not work properly as-is. I'm just running into time constraints and want to get something out there in case someone else has bandwidth.