Skip to content

Registration & Reset password#68

Open
ordavidil wants to merge 46 commits into
Gizra:masterfrom
ordavidil:reset-password
Open

Registration & Reset password#68
ordavidil wants to merge 46 commits into
Gizra:masterfrom
ordavidil:reset-password

Conversation

@ordavidil
Copy link
Copy Markdown
Contributor

selection_314

selection_315

selection_324

selection_325

@ordavidil ordavidil changed the title WIP - Reset password Reset password Jun 22, 2015
@amitaibu
Copy link
Copy Markdown
Member

Can you provide a gif that shows the flow please.

@ordavidil
Copy link
Copy Markdown
Contributor Author

Sure,

reset_password

@ordavidil
Copy link
Copy Markdown
Contributor Author

selection_326

@ordavidil
Copy link
Copy Markdown
Contributor Author

selection_329

@ordavidil
Copy link
Copy Markdown
Contributor Author

The registration flow.

registration

@ordavidil ordavidil changed the title Reset password Registration & Reset password Jun 25, 2015
Comment thread app/templates/client/app/scripts/app.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase (signup, verifyEmail)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Determine if user registration is allowed for ...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordavidil

  • Set the access_token using the Auth.setAccessToken($stateParams.accessToken)
  • Please move this to thestate resolve method and return the result of Account.verifyEmail().
// Try to verify the email when access token is being passed.
if ($state.current.name == 'verifyEmail' && accessToken) {
Account.verifyEmail(accessToken).then(function () {
$scope.emailVerified = true;
 });
 }

@YaronMiro
Copy link
Copy Markdown

@ordavidil the changes looks good, Please find out why the test is failing and fix it.

@ordavidil
Copy link
Copy Markdown
Contributor Author

@amitaibu
Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants