Add showJsError when developing. Update imagemin version.#107
Open
HelenaEksler wants to merge 3 commits into
Open
Add showJsError when developing. Update imagemin version.#107HelenaEksler wants to merge 3 commits into
HelenaEksler wants to merge 3 commits into
Conversation
Contributor
Author
HelenaEksler
changed the title
| title: 'JavaScript error', | ||
| userAgent: navigator.userAgent, | ||
| sendText: 'Send', | ||
| sendUrl: 'https://github.com/skeleton/skeleton/issues/new?title={title}&body={body}' |
Member
There was a problem hiding this comment.
the github URL should be replaced upon yo hedley -- see other places where is happens
Contributor
Author
There was a problem hiding this comment.
you are right. I've forgot to change it after synchronization.
Member
|
Contributor
Author
|
This I'm doing for including bower component. But how can I define for some custom script? Move it to the separate file? Or there is other way? |
Member
|
separate file sounds right - but better google a bit how others are doing it. |
Contributor
Author
|
@amitaibu Ready for review. |
HelenaEksler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.