fix!: prefer curl over reqwest connections if both are enabled #2232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Oct 26, 2025
Comment on lines
-219
to
-224
| #[cfg(feature = "http-client-curl")] | ||
| pub type Impl = curl::Curl; | ||
| /// The actual http client implementation, using reqwest | ||
| #[cfg(feature = "http-client-reqwest")] | ||
| pub type Impl = reqwest::Remote; | ||
|
|
There was a problem hiding this comment.
Initially I wanted to bring Impl back as it's a nice way to get the implementation of what's actually implemented, but then I realised that this is quite an implementation detail and it's probably unused outside of this crate anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of colliding
Impltype aliases forhttp-client-curlandhttp-client-reqwest, prefer curl (the one that is enabled by default) if both are available.