chore: remove unused test exports GetLocalDiffStats and WatchPRState - #975
chore: remove unused test exports GetLocalDiffStats and WatchPRState#975euxaristia wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe test export file removes two exported helper functions and their unused ChangesTest seam cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a narrowly scoped cleanup of unused test-only code with no actionable merge-blocking risk remaining after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Checked both symbols across the tree and neither has a caller. TestGetLocalDiffStatsFallsBackToOriginBase reads like it uses the exported wrapper but calls the unexported getLocalDiffStats directly, and WatchPRStateContext is the one model.go actually uses and is untouched.
Built and ran internal/tui on the head: green, go vet clean, gofmt clean. Branch is current with main.
Nice cleanup.
Summary
Remove dead test helper exports
GetLocalDiffStatsandWatchPRStatefrominternal/tui/export_test.go, which were left unreferenced following #706.Changes
internal/tui/export_test.go: RemoveGetLocalDiffStats,WatchPRState, and unusedcontext/osimports.Test plan
go run golang.org/x/tools/cmd/deadcode@latest -test ./...passes.go fmt ./...andgo vet ./...pass.go test ./internal/tui/...passes.go run ./cmd/zero-release buildandsmokepass.git diff HEAD --checkclean.Refs #904
Summary by CodeRabbit