Skip to content

feat(fireworks): add GLM-5.2 model support#1728

Closed
mvrahden wants to merge 1 commit into
Gitlawb:mainfrom
mvrahden:feat/fireworks-glm-5-2
Closed

feat(fireworks): add GLM-5.2 model support#1728
mvrahden wants to merge 1 commit into
Gitlawb:mainfrom
mvrahden:feat/fireworks-glm-5-2

Conversation

@mvrahden

@mvrahden mvrahden commented Jun 19, 2026

Copy link
Copy Markdown

Add the Fireworks-hosted glm-5p2 model to both the vendor catalog and the merged model descriptor with 1M context window.

https://fireworks.ai/models/fireworks/glm-5p2

Summary

  • A new model was added to the provider

Impact

  • none - users can choose the new model

Testing

  • bun run build
  • bun run smoke
  • bun run check

Summary by CodeRabbit

  • New Features
    • Added Fireworks GLM 5.2 model to available AI model options.

Add the Fireworks-hosted glm-5p2 model to both the vendor catalog
and the merged model descriptor with 1M context window.
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6b22dbac-a6b5-4da5-8370-3e3476bc0301

📥 Commits

Reviewing files that changed from the base of the PR and between c4aa756 and 3962fff.

📒 Files selected for processing (2)
  • src/integrations/models/fireworks-merged.ts
  • src/integrations/vendors/fireworks.ts
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript with strict mode and ESM imports

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
{src/integrations/**/*.ts,src/services/**/*.ts}

📄 CodeRabbit inference engine (AGENTS.md)

Test the exact provider/model path you changed when possible for provider modifications

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
src/integrations/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Check existing provider implementations before adding a new pattern

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
**/*.{ts,tsx,js,jsx,py,json,md}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow the existing code style in the touched files

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
**/*.{ts,tsx,js,jsx,py}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Keep comments useful and concise

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow TypeScript strict mode and type safety practices by running typecheck before submitting

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
**/*

⚙️ CodeRabbit configuration file

**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}

⚙️ CodeRabbit configuration file

{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
**

⚙️ CodeRabbit configuration file

**: # AGENTS.md - AI Agent Coding Guide

This guide is for AI coding agents working in the OpenClaude repository. Read it before changing code, and also follow CONTRIBUTING.md for contributor policy, PR expectations, review follow-up, and project scope.

Project Snapshot

OpenClaude is a coding-agent CLI for cloud and local model providers. It supports OpenAI-compatible APIs, Anthropic, Gemini, DeepSeek, Ollama, MCP, local backends, slash commands, tools, agents, and a React/Ink terminal UI.

The installed CLI runs on Node.js >=22.0.0. Bun is used for source builds, scripts, dependency management, and tests.

Work Style

  • Keep changes focused on one problem.
  • Prefer existing patterns in the file or nearby module.
  • Avoid unrelated formatting, renames, dependency changes, or broad rewrites.
  • Add or update tests when behavior changes.
  • Update docs when setup, commands, provider behavior, or user-facing behavior changes.
  • For new features, larger refactors, dependencies, or runtime changes, follow the issue-first guidance in CONTRIBUTING.md.

Stack And Conventions

  • TypeScript with strict mode and ESM imports.
  • React + Ink for terminal UI.
  • Bun lockfile and Bun scripts for development workflows.
  • Node runtime for the built CLI.
  • Python exists for legacy/local-provider helper code. Do not add new Python code or expand Python-based features unless a maintainer explicitly approves that direction.

Common libraries and patterns:

  • chalk for terminal color.
  • commander for CLI argument parsing.
  • execa for child processes.
  • Existing service, provider, settings, permission, and UI patterns over new abstractions.

Repository Map

  • src/commands/ - slash and CLI command implementations.
  • src/components/ - React/Ink UI components.
  • src/services/ - API, MCP, OAuth, wiki, voice, and other service integrations.
  • src/tools/ - tool implementations.
  • src/utils/ - shared utilities.
  • `src/integration...

Files:

  • src/integrations/vendors/fireworks.ts
  • src/integrations/models/fireworks-merged.ts
🔇 Additional comments (2)
src/integrations/vendors/fireworks.ts (1)

510-515: LGTM!

src/integrations/models/fireworks-merged.ts (1)

868-878: Add explicit validation evidence for this provider-model addition.

Please confirm bun run typecheck was run for this TS change and include the exact provider/model-path check you used for accounts/fireworks/models/glm-5p2 in the PR checks list. The current summary only mentions build, smoke, and check, so merge-readiness is not fully evidenced yet.
As per coding guidelines, "Follow TypeScript strict mode and type safety practices by running typecheck before submitting" and "Test the exact provider/model path you changed when possible."

Source: Coding guidelines


📝 Walkthrough

Walkthrough

Adds the accounts/fireworks/models/glm-5p2 ("GLM 5.2") model to two registration points: the Fireworks vendor's static catalog.models array and the merged model registry via defineModel, including metadata, capability flags, and token limits.

Changes

GLM 5.2 Model Registration

Layer / File(s) Summary
Vendor catalog and model descriptor
src/integrations/vendors/fireworks.ts, src/integrations/models/fireworks-merged.ts
Adds glm-5p2 to the Fireworks vendor catalog (id, apiName, label, modelDescriptorId) and registers it in the merged model list via defineModel with classifications, capability flags, contextWindow, and maxOutputTokens.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat(fireworks): add GLM-5.2 model support' is concise, scoped, and accurately reflects the main change—adding GLM-5.2 model support to the Fireworks integration.
Description check ✅ Passed The description covers the main changes and impact, with all required testing checkboxes completed. The 'Notes' section is minimally addressed but the essential information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Risk Surface Disclosed ✅ Passed PR touches no sensitive areas (auth, routing, permissions, network behavior, CI, release scripts). Changes are purely additive model metadata for glm-5p2; no risk surface exists.
No Hidden Policy Change ✅ Passed PR adds only standard model configuration entries for GLM-5.2 with no policy-related fields (gatewayId, trustModel, routingDefault, telemetry, permissionPolicy) modified or hidden.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevincodex1

Copy link
Copy Markdown
Contributor

this is duplicate already

@kevincodex1

Copy link
Copy Markdown
Contributor

btw . thank you so much for your contribution . theres a PR that was merged earlier that relates to this. #1689

@mvrahden

mvrahden commented Jun 19, 2026

Copy link
Copy Markdown
Author

@kevincodex1 this is not a duplicate. It is a different provider (Fireworks) that is not covered by #1689 (Z.ai).
Both providers offer the GLM5.2 model.

CC: @jatmn (I saw you also reviewed the other PR, maybe you can help?)

PS: Sorry, I should have documented it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants