feat(github): expose all 21 Copilot models with context window metadata (#822)#1535
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)**/*⚙️ CodeRabbit configuration file
Files:
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}⚙️ CodeRabbit configuration file
Files:
**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe GitHub Copilot gateway's model catalog is expanded from a minimal hardcoded set to a comprehensive enumerated list. The ChangesGitHub Copilot Model Catalog Expansion
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1a9dfdb to
b2ac4af
Compare
jatmn
left a comment
There was a problem hiding this comment.
I found an issue that needs to be addressed before this is ready.
Findings
- [P1] Complete CodeRabbit's descriptor-linkage request
src/integrations/gateways/github.ts:81
CodeRabbit's review item asked to confirm each GitHub catalogmodelDescriptorIdis registered in the descriptor registry, but the current catalog still points ten entries at descriptors that are not loaded (gpt-5.3-codex,gpt-5.2-codex,gpt-5.2,gpt-5.1-codex,gpt-5.1-codex-max,gpt-5.1-codex-mini,claude-sonnet-4-5,claude-opus-4-5,gemini-3.1-pro-preview, andgemini-3-flash-preview). The requiredsmoke-and-testscheck is red on the registry validation tests for exactly these missing descriptors, so the GitHub gateway cannot merge with an invalid descriptor registry. Please complete that review request by either adding/registering the missing model descriptors or pointing these catalog entries at the existing GitHub/Copilot descriptor IDs that are actually loaded.
jatmn
left a comment
There was a problem hiding this comment.
please roll back your prior changes and rebase on main.
please do not submit the entire codebase as new.
6dfbee4 to
ac10274
Compare
jatmn
left a comment
There was a problem hiding this comment.
Thanks for the update. I rechecked the previously discussed paths and do not see any remaining actionable issues from my side.
Fixes #822 - GitHub Copilot shows only 2 models. Changes: 2->21 models with contextWindow, maxOutputTokens, modelDescriptorId. All metadata reconciled against descriptors.
Summary by CodeRabbit