fix: add error context to silent catches and debugger detection

[skyhighbg22-jpg]

Replace silent catch handlers and remove dead debug code so failures and stale instrumentation are no longer hidden.

main.tsx

• migrateChangelogFromConfig().catch(() => {}) now logs the error via logError (with the original error as cause). Migration still retries on the next startup, but the failure is now visible.
• Debugger-detection branch now writes a stderr message before process.exit(1) so users see why the process exited.
• Silent catch block in logManagedSettings now calls logForDebugging instead of swallowing the error.
• Three void getSystemContext() calls now use .catch(logError) so git-hook/config failures are surfaced.

src/utils/worktree.ts

• Two diagnostic console.log call sites (Using worktree via hook: ... and Created worktree: ... (based on ...)) are converted to logForDebugging. They were diagnostic noise that polluted stdout in normal use; routing them through the debug log pipeline lets the matching biome-ignore comments go away.
• The iTerm2 tip console.log further down is intentionally user-facing guidance and is left untouched.

src/utils/fileHistory.ts

• Removed the dead ENABLE_DUMP_STATE flag (hard-coded to false) and its maybeDumpStateForDebug helper, both call sites in fileHistoryTrackEdit / fileHistoryMakeSnapshot, and the now-unused inspect import from util. State-dump debug output can be re-introduced with a real debug flag if it is ever needed.

Summary by CodeRabbit

• Chores

  • Improved startup error reporting and logging consistency so initialization failures are now surfaced and logged.
  • Removed optional debug state dumping functionality.
  • Updated logging output for worktree operations to use consistent debug-level logs.

• Bug Fixes

  • Ensured non-blocking startup tasks log failures instead of being silently ignored.

[jatmn]

I found an issue that needs to be addressed before this is ready.

Findings

• [P2] Finish or remove the advertised debug-cleanup changes
  src/main.tsx:351
  The PR description says this fixes the silent migrateChangelogFromConfig catch and cleans debug artifacts in src/utils/worktree.ts and src/utils/fileHistory.ts, but the patch only changes src/main.tsx. On this branch, migrateChangelogFromConfig().catch(() => {}) still silently ignores migration failures, worktree.ts still has the three console.log call sites called out in the PR body, and fileHistory.ts still has console.error(inspect(state, false, 5)) behind ENABLE_DUMP_STATE. As written, the PR does not deliver a meaningful part of its stated scope, and reviewers/users would believe those noisy debug paths and silent errors were fixed when they were not. Please either implement those advertised changes or narrow the PR description to the behavior this patch actually changes.

[jatmn]

Thanks for the update. I rechecked the changed paths and found an issue that still needs to be addressed.

Findings

• [P2] Finish or remove the advertised debug-cleanup changes
  src/main.tsx:351
  The PR description still says this fixes the silent migrateChangelogFromConfig catch and cleans debug artifacts in src/utils/worktree.ts and src/utils/fileHistory.ts, but the patch still only changes src/main.tsx. On this branch, migrateChangelogFromConfig().catch(() => {}) still silently ignores migration failures, worktree.ts still has the three console.log call sites called out in the PR body, and fileHistory.ts still has console.error(inspect(state, false, 5)) behind ENABLE_DUMP_STATE. As written, the PR still does not deliver a meaningful part of its stated scope, and reviewers/users would believe those noisy debug paths and silent errors were fixed when they were not. Please either implement those advertised changes or narrow the PR description to the behavior this patch actually changes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cc0f75b2-179b-479a-8533-e5418369c227

📥 Commits

Reviewing files that changed from the base of the PR and between 8377a7b and dc947a7.

📒 Files selected for processing (1)

• src/main.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• src/main.tsx

---

📝 Walkthrough

Walkthrough

Adds logging for previously-unhandled startup errors, changes two console debug prints to use the debug logger, and removes an unused debug state-dump facility. No exported/public signatures changed.

Changes

Observability and Debug Improvements

Layer / File(s)	Summary
Startup path error logging src/main.tsx	Managed settings errors are logged via logForDebugging; debugger-detected external-build exit writes a message to process.stderr; non-blocking changelog migration errors are caught, wrapped in an Error with cause, and logged via logError; getSystemContext() calls in prefetch and print-mode paths now attach .catch(logError) so failures are reported.
Debug message logging migration src/utils/worktree.ts	Worktree messages previously emitted with console.log ("Using worktree via hook", "Created worktree") are now emitted with logForDebugging().
Remove debug state dumping facility src/utils/fileHistory.ts	Deletes the util.inspect import, the ENABLE_DUMP_STATE constant and maybeDumpStateForDebug helper, and removed calls to that helper from fileHistoryTrackEdit and fileHistoryMakeSnapshot.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰
I hopped through startup's silent night,
And nudged the logs to show the light.
Old dumps were cleared beneath my paws,
Now errors speak without a pause.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objectives: adding error context to silent catch handlers and improving debugger detection error visibility.
Description check	✅ Passed	The pull request description provides comprehensive coverage of changes across all three files with clear explanations of what changed and why, but lacks explicit Testing and Impact sections required by the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main.tsx`:
- Around line 226-229: The catch block after calling logManagedSettings
currently swallows the exception; modify the catch to capture the error (e.g.,
catch (err)) and pass that error into the debug log call so the exception
details are preserved—update the logForDebugging('[main] logManagedSettings
failed', { level: 'debug' }) invocation to include the caught error (err or
err.message/stack) so callers can see the failure context for the
logManagedSettings call.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 716c4aea-6356-4dae-ac0c-eecdd395c144

📥 Commits

Reviewing files that changed from the base of the PR and between e357d59 and 8377a7b.

📒 Files selected for processing (3)

• src/main.tsx
• src/utils/fileHistory.ts
• src/utils/worktree.ts

💤 Files with no reviewable changes (1)

• src/utils/fileHistory.ts

[jatmn]

Thanks for the update. I rechecked the previously discussed paths and found one item that still needs to be addressed.

Findings

• [P2] Complete CodeRabbit's request to keep the managed-settings error context
  src/main.tsx:226
  CodeRabbit's review thread is marked resolved, but the current patch still uses a bare catch around logManagedSettings and logs only [main] logManagedSettings failed. That means any failure while reading policy settings, formatting the managed keys, or sending the analytics event is still reduced to a generic message with no exception details, which undercuts the PR's stated goal of adding error context to silent catches. Please complete that review request by catching the error value and including its message/stack in the debug log.

[jatmn]

Thanks for the update. I rechecked the previously discussed paths and found one item that still needs to be addressed.

Findings

• [P2] Surface the changelog cache-write failures too
  src/utils/releaseNotes.ts:226
  The new .catch(logError) around migrateChangelogFromConfig() only reports errors that escape the migration, but the migration still catches every mkdir/writeFile failure internally and treats it like the cache file already existed. If creating the changelog cache fails for another reason, the failure is still silent and saveGlobalConfig(({ cachedChangelog: _, ...rest }) => rest) then removes the legacy value, so the advertised "migration failures are now surfaced / will retry next startup" behavior does not hold for that write path. Please either rethrow/log non-EEXIST write failures before removing cachedChangelog, or narrow the PR description so it does not claim those migration failures are now visible.

[kevincodex1]

LGTM