Skip to content

Add escaping for bad platform string. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add escaping for bad platform string. #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/nuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ Nuts.prototype.onDownload = function(req, res, next) {
});
}

if (!asset) throw new Error("No download available for platform "+platform+" for version "+version.tag+" ("+(channel || "beta")+")");
if (!asset) throw new Error("No download available for platform "+_.escape(platform)+" for version "+version.tag+" ("+(channel || "beta")+")");

// Call analytic middleware, then serve
return that.serveAsset(req, res, version, asset);
Expand All @@ -202,7 +202,7 @@ Nuts.prototype.onUpdateRedirect = function(req, res, next) {
if (!req.query.version) throw new Error('Requires "version" parameter');
if (!req.query.platform) throw new Error('Requires "platform" parameter');

return res.redirect('/update/'+req.query.platform+'/'+req.query.version);
return res.redirect('/update/'+_.escape(req.query.platform)+'/'+req.query.version);
})
.fail(next);
};
Expand Down