Skip to content

Temporarily disable the InlineLink hover preview. #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Temporarily disable the InlineLink hover preview. #3335

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71dfd77
Investigate performance issues with InlineLink.
emmerich Jun 16, 2025
7e06549
Fix ts
emmerich Jun 16, 2025
25f768c
Remove tooltip
emmerich Jun 16, 2025
60d67fd
update
emmerich Jun 16, 2025
b8ab640
Merge branch 'main' into stevenh/perf-investigations
emmerich Jun 16, 2025
7f31589
Merge branch 'main' into stevenh/perf-investigations
emmerich Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 22 additions & 25 deletions packages/gitbook/src/components/DocumentView/InlineLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { resolveContentRef } from '@/lib/references';
import { Icon } from '@gitbook/icons';
import { StyledLink } from '../primitives';
import type { InlineProps } from './Inline';
import { InlineLinkTooltip } from './InlineLinkTooltip';
import { Inlines } from './Inlines';

export async function InlineLink(props: InlineProps<DocumentInlineLink>) {
Expand Down Expand Up @@ -32,30 +31,28 @@ export async function InlineLink(props: InlineProps<DocumentInlineLink>) {
const isExternal = inline.data.ref.kind === 'url';

return (
<InlineLinkTooltip inline={inline} context={context.contentContext} resolved={resolved}>
<StyledLink
href={resolved.href}
insights={{
type: 'link_click',
link: {
target: inline.data.ref,
position: SiteInsightsLinkPosition.Content,
},
}}
>
<Inlines
context={context}
document={document}
nodes={inline.nodes}
ancestorInlines={[...ancestorInlines, inline]}
<StyledLink
href={resolved.href}
insights={{
type: 'link_click',
link: {
target: inline.data.ref,
position: SiteInsightsLinkPosition.Content,
},
}}
>
<Inlines
context={context}
document={document}
nodes={inline.nodes}
ancestorInlines={[...ancestorInlines, inline]}
/>
{isExternal ? (
<Icon
icon="arrow-up-right"
className="ml-0.5 inline size-3 links-accent:text-tint-subtle"
/>
{isExternal ? (
<Icon
icon="arrow-up-right"
className="ml-0.5 inline size-3 links-accent:text-tint-subtle"
/>
) : null}
</StyledLink>
</InlineLinkTooltip>
) : null}
</StyledLink>
);
}