Skip to content

Conversation

sylwia-budzynska
Copy link

It looks like the paths in the example were switched around. @anticomputer is this correct?

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 19:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates environment variable paths in README documentation to correct inconsistent path mappings between the example configuration and deployment command.

  • Standardizes CODEQL_DBS_BASE_PATH to use "/codeql_databases" in the environment configuration example
  • Updates the deployment example to use consistent path mappings between MY_DATA and CODEQL_DBS_BASE_PATH

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@m-y-mo
Copy link
Contributor

m-y-mo commented Oct 10, 2025

It does look like it, but then in the second example, /codeql_databases is not mounted, so maybe it makes more sense to change both the CODEQL_DBS_BASE_PATH to /app/my_data/codeql_databases instead so at least it'd be mounted in the docker container in the examples?


```sh
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/codeql_databases CODEQL_DBS_BASE_PATH=/app/my_data docker/run.sh -t custom_taskflow
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/codeql_databases docker/run.sh -t custom_taskflow
Copy link
Author

@sylwia-budzynska sylwia-budzynska Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/codeql_databases docker/run.sh -t custom_taskflow
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/app/my_data/codeql_databases docker/run.sh -t custom_taskflow

Copy link
Author

@sylwia-budzynska sylwia-budzynska Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-y-mo Sounds good, I'll test it sometime at the end of the next week 👍

# MCP configs
GITHUB_PERSONAL_ACCESS_TOKEN=<your_github_token>
CODEQL_DBS_BASE_PATH="/app/my_data/"
CODEQL_DBS_BASE_PATH="/codeql_databases"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CODEQL_DBS_BASE_PATH="/codeql_databases"
CODEQL_DBS_BASE_PATH="/app/my_data/codeql_databases"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants