-
Notifications
You must be signed in to change notification settings - Fork 5
Update environment variable paths in README #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated CODEQL_DBS_BASE_PATH in README.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates environment variable paths in README documentation to correct inconsistent path mappings between the example configuration and deployment command.
- Standardizes CODEQL_DBS_BASE_PATH to use "/codeql_databases" in the environment configuration example
- Updates the deployment example to use consistent path mappings between MY_DATA and CODEQL_DBS_BASE_PATH
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
It does look like it, but then in the second example, |
|
||
```sh | ||
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/codeql_databases CODEQL_DBS_BASE_PATH=/app/my_data docker/run.sh -t custom_taskflow | ||
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/codeql_databases docker/run.sh -t custom_taskflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/codeql_databases docker/run.sh -t custom_taskflow | |
MY_TASKFLOWS=~/my_taskflows MY_DATA=~/app/my_data CODEQL_DBS_BASE_PATH=/app/my_data/codeql_databases docker/run.sh -t custom_taskflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-y-mo Sounds good, I'll test it sometime at the end of the next week 👍
# MCP configs | ||
GITHUB_PERSONAL_ACCESS_TOKEN=<your_github_token> | ||
CODEQL_DBS_BASE_PATH="/app/my_data/" | ||
CODEQL_DBS_BASE_PATH="/codeql_databases" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEQL_DBS_BASE_PATH="/codeql_databases" | |
CODEQL_DBS_BASE_PATH="/app/my_data/codeql_databases" |
It looks like the paths in the example were switched around. @anticomputer is this correct?