Scroll view behavior fix#77
Closed
jasonaibrahim wants to merge 2 commits intoGitHawkApp:masterfrom
jasonaibrahim:scroll-view-behavior-fix
Closed
Scroll view behavior fix#77jasonaibrahim wants to merge 2 commits intoGitHawkApp:masterfrom jasonaibrahim:scroll-view-behavior-fix
jasonaibrahim wants to merge 2 commits intoGitHawkApp:masterfrom
jasonaibrahim:scroll-view-behavior-fix
Conversation
…scroll view (cherry picked from commit d1b7850)
Member
|
@jasonaibrahim can you detail this bug a little more? I'm not sure I've seen it before. How do I repro? |
Contributor
Author
|
@rnystrom sorry for slow replies, been travelling. i will put together a little demo repo in the next few days |
Contributor
Author
|
Alright I have a demo repo up and able to reproduce. Reproduce Issue
Fix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior
The scroll view will jump to the middle when a keystroke is received by the keyboard no matter where the scroll view currently is.
Fix
Remove calls to
setNeedsLayoutto avoid the scroll view from jumping