feat(checks): default comparison key to trace.last.outputs - #2663
Closed
davidberenstein1957 wants to merge 2 commits into
Closed
feat(checks): default comparison key to trace.last.outputs#2663davidberenstein1957 wants to merge 2 commits into
davidberenstein1957 wants to merge 2 commits into
Conversation
Align Equals and other comparison checks with judges so callers can omit key= when reading the last interaction outputs. Document extraction parameters for built-ins in the checks README. Closes #2659
Reformat README snippets so make check passes with ruff format on CI.
Member
Author
|
Superseded by #2754, which includes this default plus the param renames, and has no conflicts. Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComparisonCheck.keytotrace.last.outputssoEquals(expected_value=...)(and siblings) match judge DX without an explicitkey=libs/giskard-checks/README.mdanswer_key/text_keynames kept)Closes #2659
Test plan
make test-unit PACKAGE=giskard-checks(757 passed, 4 skipped)Equals(expected_value="Paris")against a scenario whose last outputs are"Paris"